Bug in add_rpm_repo.sh

[r_hartman]

Just installed FreeOffice as instructed on CentOS7 and installation went smoothly.
However, when adding the SoftMaker repo using script /usr/share/freeoffice2018/add_rpm_repo.sh an error occurred:

Code: Select all

$ sudo /usr/share/freeoffice2018/add_rpm_repo.sh
Adding the SoftMaker repository to keep SoftMaker Office up to date...
Importing the key for the SoftMaker repository...
/usr/share/freeoffice2018/add_rpm_repo.sh: line 63: dnf: command not found
All done! 

This is caused by both the dnf and yum existence test using 'which yum', rather than using 'which dnf' on the dnf test:

Code: Select all

        rpmkeys --import $APPPATH/softmaker.repository.gpg
        DNF=$(which yum 2>/dev/null)
        if [ "M$DNF" != "M" ] ; then
                dnf -q makecache -y --disablerepo=* --enablerepo=SoftMaker_Office_Repository
        else
                YUM=$(which yum 2>/dev/null)
                if [ "M$YUM" != "M" ] ; then
                        yum -q makecache -y --disablerepo=* --enablerepo=SoftMaker_Office_Repository
                fi
        fi

Changing line 61 to

Code: Select all

DNF=$(which dnf 2>/dev/null)

fixes it.

Please fix for the next release.

[miguel-c]

Hi, sorry for the delay. I've just reported the issue to the developers.

[miguel-c]

Hi, the issue has been fixed and the fix will be included in the next service pack